Improve accessibility autofill performance #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4276 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 445 445
Lines 38887 38888 +1
Branches 5468 5469 +1
==========================================
Hits 34601 34601
Misses 2369 2369
- Partials 1917 1918 +1 ☔ View full report in Codecov by Sentry. |
david-livefront
force-pushed
the
accessibility-autofill-performance
branch
from
5645ab3
to
0cd2b05
Compare
SaintPatrck
approved these changes
Nov 11, 2024
| fun processAccessibilityEvent(rootAccessibilityNodeInfo: AccessibilityNodeInfo?) | ||
| fun processAccessibilityEvent( | ||
| event: AccessibilityEvent, | ||
| rootAccessibilityNodeInfoProvider: () -> AccessibilityNodeInfo?, |
|
Thanks @patrick-bitwarden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This PR adds some additional performance improvements to the accessibility autofill by deferring the call to the
rootAccessibilityNodeInfountil after all other checks have passed.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes