-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14596] Sync on database scheme change #4257
[PM-14596] Sync on database scheme change #4257
Conversation
databaseSchemeManager | ||
.lastDatabaseSchemeChangeInstantFlow | ||
.filterNotNull() | ||
.onEach { syncIfNecessary() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to just call sync explicitly?
I don't think it will make a huge difference
New Issues
|
Trigger a sync when the database schema changes. This ensures that the client and server are in sync after a schema update.
b4cd063
to
c4fa2cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/hotfix-v2024.11.2 #4257 +/- ##
============================================================
Coverage ? 88.94%
============================================================
Files ? 439
Lines ? 38093
Branches ? 5341
============================================================
Hits ? 33880
Misses ? 2347
Partials ? 1866 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14596
📔 Objective
Trigger a sync when the database schema changes. This ensures that the client and server are in sync after a schema update.
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes