Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14596] Sync on database scheme change #4257

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Nov 7, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14596

📔 Objective

Trigger a sync when the database schema changes. This ensures that the client and server are in sync after a schema update.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

databaseSchemeManager
.lastDatabaseSchemeChangeInstantFlow
.filterNotNull()
.onEach { syncIfNecessary() }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to just call sync explicitly?

I don't think it will make a huge difference

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Logo
Checkmarx One – Scan Summary & Details4cd6101b-4d41-4bdb-b86f-4fba7d94ffb2

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 29 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt: 94 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 251 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 240 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 262 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Use_of_Hardcoded_Password /app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20 Attack Vector

Trigger a sync when the database schema changes. This ensures that the client and server are in sync after a schema update.
@SaintPatrck SaintPatrck force-pushed the hotfix-v2024.11.2/sync-on-schema-change branch from b4cd063 to c4fa2cb Compare November 7, 2024 20:43
@SaintPatrck SaintPatrck marked this pull request as ready for review November 7, 2024 20:45
@SaintPatrck SaintPatrck changed the title Sync on database scheme change [PM-14596] Sync on database scheme change Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/hotfix-v2024.11.2@b5752c1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...platform/datasource/disk/SettingsDiskSourceImpl.kt 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             release/hotfix-v2024.11.2    #4257   +/-   ##
============================================================
  Coverage                             ?   88.94%           
============================================================
  Files                                ?      439           
  Lines                                ?    38093           
  Branches                             ?     5341           
============================================================
  Hits                                 ?    33880           
  Misses                               ?     2347           
  Partials                             ?     1866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck merged commit 3c77933 into release/hotfix-v2024.11.2 Nov 8, 2024
8 checks passed
@SaintPatrck SaintPatrck deleted the hotfix-v2024.11.2/sync-on-schema-change branch November 8, 2024 14:29
@SaintPatrck SaintPatrck restored the hotfix-v2024.11.2/sync-on-schema-change branch November 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants