Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14589] Prevent SSH key item creation #4251

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Nov 6, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14589

📔 Objective

Removed the SSH key feature flag and disabled the SSH key item type option in VaultAddEdit screen.

The SSH key item type option is currently hidden until the SDK supports it.

📸 Screenshots

Before After
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Removed the SSH key feature flag and disabled the SSH key item type option in `VaultAddEdit` screen.

The SSH key item type option is currently hidden until the SDK supports it.
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Logo
Checkmarx One – Scan Summary & Details5cb670cc-110c-4b73-8f69-46768c8e5da1

No New Or Fixed Issues Found

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (e397c03) to head (5f2d8c5).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4251      +/-   ##
==========================================
- Coverage   89.05%   89.04%   -0.01%     
==========================================
  Files         445      445              
  Lines       38786    38770      -16     
  Branches     5422     5421       -1     
==========================================
- Hits        34539    34523      -16     
  Misses       2367     2367              
  Partials     1880     1880              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@david-livefront david-livefront added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 2c40a7f Nov 11, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-14589/disable-ssh-key-item-creation branch November 11, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants