PM-14255: Remove accessibility logic to improve overall performance #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
SaintPatrck
previously approved these changes
Oct 30, 2024
david-livefront
force-pushed
the
PM-14255-accessibility-performance
branch
2 times, most recently
from
99d9c01
to
ac10fcf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
=======================================
Coverage ? 89.05%
=======================================
Files ? 445
Lines ? 38645
Branches ? 5403
=======================================
Hits ? 34414
Misses ? 2357
Partials ? 1874 ☔ View full report in Codecov by Sentry. |
david-livefront
commented
Oct 30, 2024
| @@ -22,8 +22,7 @@ class BitwardenAccessibilityService : AccessibilityService() { | |||
| lateinit var processor: BitwardenAccessibilityProcessor | |||
|
|
|||
| override fun onAccessibilityEvent(event: AccessibilityEvent) { | |||
| if (rootInActiveWindow?.packageName != event.packageName) return | |||
There was a problem hiding this comment.
So I left the check in but reduced our calls to rootInActiveWindow down to one. This should still have a positive impact on performance without losing the package check.
david-livefront
force-pushed
the
PM-14255-accessibility-performance
branch
from
ac10fcf
to
947a93d
Compare
SaintPatrck
approved these changes
Oct 31, 2024
|
Thanks @SaintPatrck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14255
📔 Objective
This PR makes two major performance improvements for the accessibility service.
typeWindowContentChangedevent type which occurs much more frequently than needed.RootInActiveWindowwhich can take a long time to access.📸 Screenshots
before.mp4
after.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes