[PM-13360] Respect manage permission to assign collections #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4190 +/- ##
==========================================
- Coverage 89.02% 88.99% -0.04%
==========================================
Files 445 445
Lines 38819 38850 +31
Branches 5440 5458 +18
==========================================
+ Hits 34558 34573 +15
Misses 2368 2368
- Partials 1893 1909 +16 ☔ View full report in Codecov by Sentry. |
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
3 times, most recently
from
17d36f0
to
9850607
Compare
SaintPatrck
force-pushed
the
PM-13360/collection-association-permission
branch
from
9d8e0f0
to
76954d4
Compare
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
4 times, most recently
from
4d2f1c2
to
70a7e99
Compare
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt
Outdated
Show resolved
Hide resolved
SaintPatrck
force-pushed
the
PM-13360/collection-association-permission
branch
from
76954d4
to
e89cc11
Compare
|
No New Or Fixed Issues Found |
Base automatically changed from
PM-12922/delete-collection-permission
to
main
November 7, 2024 00:03
This commit prevents users from assigning items to collections if the item is already in a read-only collection where the user does not have "manage" permission. This change ensures that users with limited permissions cannot modify items in a way that violates the collection's access controls.
SaintPatrck
force-pushed
the
PM-13360/collection-association-permission
branch
from
e89cc11
to
7e1e8d3
Compare
| @@ -7,9 +7,12 @@ import com.bitwarden.vault.CipherView | |||
| * | |||
| * @property cipher The cipher view for the item. | |||
| * @property totpCodeItemData The data for the totp code. | |||
| * @property canDelete Whether the item can be deleted. | |||
| * @property canAssociateToCollections Whether the item can be associated to a collection. | |||
david-livefront
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13360
📔 Objective
This commit prevents users from assigning items to collections if the item is already in a read-only collection where the user does not have "manage" permission.
This change ensures that users with limited permissions cannot modify items in a way that violates the collection's access controls.
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes