Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14201: Update the default divider thickness #4182

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 28, 2024

🎟️ Tracking

PM-14201

📔 Objective

This PR updates the default divider thickness across the app.

There should be no functional changes in this PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@05c7686). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4182   +/-   ##
=======================================
  Coverage        ?   88.95%           
=======================================
  Files           ?      439           
  Lines           ?    38142           
  Branches        ?     5340           
=======================================
  Hits            ?    33930           
  Misses          ?     2347           
  Partials        ?     1865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 150c8e0 Oct 29, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-14201-divider-thickness branch October 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants