PM-13908 fixing copy on step2 and step3 and making vault url dynamic #4154
Conversation
dseverns-livefront
requested review from
brian-livefront,
david-livefront,
ahaisting-livefront and
a team
as code owners
dseverns-livefront
force-pushed
the
import-logins-small-fixes
branch
from
f49c0e7
to
fe3e581
Compare
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4154 +/- ##
==========================================
- Coverage 88.95% 88.95% -0.01%
==========================================
Files 439 439
Lines 38099 38111 +12
Branches 5336 5338 +2
==========================================
+ Hits 33891 33901 +10
Misses 2346 2346
- Partials 1862 1864 +2 ☔ View full report in Codecov by Sentry. |
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsViewModel.kt
Outdated
Show resolved
Hide resolved
dseverns-livefront
force-pushed
the
import-logins-small-fixes
branch
from
2839dca
to
85e9ade
Compare
| @@ -1055,7 +1055,7 @@ Skift til denne konto?</string> | |||
| <string name="then_done_highlight">dernæst Færdig</string> | |||
| <string name="for_your_security_be_sure_to_delete_your_saved_password_file">Sørg af sikkerhedshensyn for at slette den gemte adgangskodefil.</string> | |||
| <string name="delete_your_saved_password_file">slet den gemte adgangskodefil.</string> | |||
| <string name="need_help_checkout_out_import_help">Behov for hjælp? Tjek import-hjælp ud.</string> | |||
| <string name="need_help_check_out_import_help">Behov for hjælp? Tjek import-hjælp ud.</string> | |||
There was a problem hiding this comment.
You do not need to update these other files, just the base one.
The next Crowdin sync will take care of the rest.
There was a problem hiding this comment.
So I rolled this back, it does seem to be what is failing the build. Cause the that version of the string no longer exists in the default version. Are we ok to merge, crowdin is a black box to me.
There was a problem hiding this comment.
Hmmm, @SaintPatrck do we have a good way of doing this?
There was a problem hiding this comment.
We can ignore ExtraTranslation since Crowdin will be managing this. I opened #4176 to ignore it.
dseverns-livefront
force-pushed
the
import-logins-small-fixes
branch
from
85e9ade
to
35609ff
Compare
dseverns-livefront
force-pushed
the
import-logins-small-fixes
branch
from
35609ff
to
3a0dfb6
Compare
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13908
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes