Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-951: Adding missing IDs for Attachment rows #4148

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

ifernandezdiaz
Copy link
Contributor

@ifernandezdiaz ifernandezdiaz commented Oct 24, 2024

🎟️ Tracking

📔 Objective

This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Logo
Checkmarx One – Scan Summary & Details1eb74d26-4d63-4f70-ba06-3c2437cf6378

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (ef1e840) to head (95ce316).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4148   +/-   ##
=======================================
  Coverage   88.91%   88.92%           
=======================================
  Files         437      437           
  Lines       37933    37945   +12     
  Branches     5324     5324           
=======================================
+ Hits        33730    33742   +12     
  Misses       2347     2347           
  Partials     1856     1856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ifernandezdiaz ifernandezdiaz added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 0ff2fe6 Oct 24, 2024
9 checks passed
@ifernandezdiaz ifernandezdiaz deleted the QA-951/adding-testTag-for-attachment-cells branch October 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants