PM-13886 show dialog when no logins were imported #4139
Merged
+210
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseverns-livefront
requested review from
brian-livefront,
david-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
dseverns-livefront
force-pushed
the
PM-13886-no-logins-imported
branch
from
ecd4806
to
5df89c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4139 +/- ##
==========================================
- Coverage 88.95% 88.95% -0.01%
==========================================
Files 439 439
Lines 38051 38064 +13
Branches 5333 5336 +3
==========================================
+ Hits 33848 33858 +10
- Misses 2345 2346 +1
- Partials 1858 1860 +2 ☔ View full report in Codecov by Sentry. |
| val itemsAvailable = vaultDiskSource | ||
| .getCiphers(userId) | ||
| .firstOrNull() | ||
| ?.isNotEmpty() ?: false |
There was a problem hiding this comment.
Can we move the ?: false down a line
app/src/main/res/values/strings.xml
Outdated
| @@ -1061,4 +1061,5 @@ Do you want to switch to this account?</string> | |||
| <string name="save_the_exported_file_highlight">Save the exported file</string> | |||
| <string name="this_is_not_a_recognized_bitwarden_server_you_may_need_to_check_with_your_provider_or_update_your_server">This is not a recognized Bitwarden server. You may need to check with your provider or update your server.</string> | |||
| <string name="syncing_logins_loading_message">Syncing logins...</string> | |||
| <string name="no_logins_were_imported">No logins were imported</string> | |||
There was a problem hiding this comment.
Can you make sure the indentation here matches.
|
|
||
| @Suppress("MaxLineLength") | ||
| @Test | ||
| fun `syncForResult should return success result with itemsAvailable = false when sync succeeds and ciphers list is empty`() = runTest { |
There was a problem hiding this comment.
Wanna run the formatter here, even with the suppression, runTest { should be on it's own line
david-livefront
previously approved these changes
Oct 24, 2024
dseverns-livefront
force-pushed
the
PM-13886-no-logins-imported
branch
from
909d73e
to
73de326
Compare
david-livefront
previously approved these changes
Oct 24, 2024
david-livefront
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13886
📔 Objective
📸 Screenshots
pm13886.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes