This PR adds the TOTP matching flow to the app

[david-livefront]

🎟️ Tracking

PM-13020
PM-13022
PM-13023
PM-13024
PM-13081
PM-13082
PM-13083

📔 Objective

This PR updates the VaultItemListingScreen and VaultAddEditScreen to support a totp special circumstance.

📸 Screenshots

Screen_recording_20241007_164003.mp4

[github-actions]

Checkmarx One – Scan Summary & Details – dfe68a4d-34ca-4bd8-b553-a693ec776716

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11	Attack Vector
	Use_of_Hardcoded_Password	/app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 349
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 349
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 241

[codecov]

Codecov Report

Attention: Patch coverage is 56.32184% with 38 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (0cb8e36) to head (7a809ea).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
.../ui/vault/feature/addedit/VaultAddEditViewModel.kt	51.21%	7 Missing and 13 partials ⚠️
...ult/feature/itemlisting/VaultItemListingContent.kt	27.27%	7 Missing and 1 partial ⚠️
...t/feature/itemlisting/VaultItemListingViewModel.kt	68.18%	1 Missing and 6 partials ⚠️
...vault/feature/addedit/util/CipherViewExtensions.kt	0.00%	0 Missing and 1 partial ⚠️
...i/vault/feature/addedit/util/TotpDataExtensions.kt	80.00%	0 Missing and 1 partial ⚠️
...ault/feature/itemlisting/VaultItemListingScreen.kt	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
- Coverage   88.93%   88.89%   -0.05%     
==========================================
  Files         428      429       +1     
  Lines       35300    35338      +38     
  Branches     5176     5192      +16     
==========================================
+ Hits        31394    31413      +19     
- Misses       2099     2106       +7     
- Partials     1807     1819      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dseverns-livefront]

👍

[dseverns-livefront]

💭 Not something to block the PR, more just a thought about the order of the nesting, does this technically create an empty item every-time where if we were using positions(listState.scrollTo(0)) could throw of the the index?

[david-livefront]

It does make an empty item. I was following the pattern on this screen but we probably should investigate this in the future.

[dseverns-livefront]

[david-livefront]

Thanks @dseverns-livefront