PM-13019: Add special circumstance to navigate to the vault listing UI for TOTP code #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4033 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 428 428
Lines 35281 35300 +19
Branches 5171 5176 +5
=======================================
+ Hits 31373 31391 +18
- Misses 2102 2103 +1
Partials 1806 1806 ☔ View full report in Codecov by Sentry. |
SaintPatrck
reviewed
Oct 7, 2024
...est/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensionsTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt
Outdated
Show resolved
Hide resolved
david-livefront
force-pushed
the
PM-13019-totp-flow
branch
from
9641163
to
54d4552
Compare
SaintPatrck
approved these changes
Oct 7, 2024
|
Thanks @SaintPatrck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13019
📔 Objective
This PR adds the special circumstance logic to route the user to the vault listing screen for a totp code intent.
Note that the Android Manifest has not bee updated to support this flow in this PR. That will occur in a future PR.
📸 Screenshots
Screen_recording_20241004_132937.mp4