Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-12773 show autofill card when user skipped this step in onboarding #4021

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

dseverns-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12773

📔 Objective

  • When boolean field is stored and true to show notification badges, we want to show the action card in the "Autofill" settings menu.

📸 Screenshots

pm12773.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Logo
Checkmarx One – Scan Summary & Details4dca0a20-37fb-4c2f-85f4-21fa19a895ac

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (1d84479) to head (8d5148f).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...orm/feature/settings/autofill/AutoFillViewModel.kt 97.36% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
+ Coverage   88.89%   88.90%   +0.01%     
==========================================
  Files         426      426              
  Lines       35192    35234      +42     
  Branches     5162     5167       +5     
==========================================
+ Hits        31284    31325      +41     
  Misses       2110     2110              
- Partials     1798     1799       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront merged commit 83652c9 into main Oct 4, 2024
9 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-12773-autofill-card branch October 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants