Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12739] adjusted generator length to not be lower than minimum length #4016

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

aj-rosado
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12739

📔 Objective

When the sum of minimum special, numbers, lowercase and uppercase exceeded the minimum length, the length was not being properly adjusted and was throwing an error on the SDK.
This should fix it by using the calculatedMinimumLength that takes variables that into consideration.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Logo
Checkmarx One – Scan Summary & Detailscda9964c-b6cb-41b3-83df-8700456984d9

No New Or Fixed Issues Found

@aj-rosado aj-rosado force-pushed the PM-12739/generator-policy-minimum-value-error branch from ad9c5c3 to 949e7a7 Compare October 2, 2024 17:14
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (8e092ef) to head (949e7a7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4016   +/-   ##
=======================================
  Coverage   88.86%   88.87%           
=======================================
  Files         425      425           
  Lines       35091    35095    +4     
  Branches     5142     5142           
=======================================
+ Hits        31185    31189    +4     
  Misses       2112     2112           
  Partials     1794     1794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aj-rosado aj-rosado merged commit e2e5042 into main Oct 3, 2024
9 checks passed
@aj-rosado aj-rosado deleted the PM-12739/generator-policy-minimum-value-error branch October 3, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants