[PM-13011] Allow relevant browsers in the privacy/security/FOSS space to use auto-fill and passkeys

[lucasmz-dev]

🎟️ Tracking

Fixes #3949
Contains extra edge-cases for other related projects.

📔 Objective

Bring support for Bitwarden passkeys and auto-fill to browsers used in the privacy, security, or FOSS communities.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13011

[SaintPatrck]

Hey @lucasmz-dev
Thank you for submitting these changes. Ideally we would separate the list from Google and the list maintained by the Bitwarden community. Taking that approach makes it easier to automate updating our Google list in the future.

While we are tracking this in our backlog, I'd be happy to approve your PR as a first step towards our end goal. I only ask that you move the entries to a new fido2_privileged_community.json file that is sorted alphabetically by package name.

[SkewedZeppelin]

@SaintPatrck

While we are tracking this in our backlog,

I totally understand your reasoning, but kindly pushing it to a backlog only reinforces Google's anti-competitive behavior here.
Honestly I'm fine with it, more fodder for their antitrust lawsuits.

You also previously mentioned it as a Bitwarden maintained list, and buried the lede until now that it was really Google's:

our list of known privileged application

[lucasmz-dev]

While we are tracking this in our backlog, I'd be happy to approve your PR as a first step towards our end goal. I only ask that you move the entries to a new fido2_privileged_community.json file that is sorted alphabetically by package name.

I'm fine with doing that, just beware CalyxOS' Chromium uses the package name org.chromium.chrome, which is also on the Google list, so whatever code you guys would have written would have to deal with that.

I just ask for this to please be included sometime soon because restricting this to Google-approved™ list as @SkewedZeppelin said doesn't make sense.

[lucasmz-dev]

@SaintPatrck How does this look?

[lucasmz-dev]

Backup of the previous contents on /backup-private-roms

[SaintPatrck]

Hi @SkewedZeppelin 👋 ,

I appreciate your feedback.

We are not intentionally limiting support to only browsers approved by Google. Previously, we haven't received any reports of issues related to missing browsers. However, we recognize the need for broader support and we will be adding browsers requested by the community.

It was not my intent to imply the list is generated by Bitwarden. It is indeed sourced from Google as a recommended starting point to ensure immediate support for commonly used browsers. We will be updating the filename to clearly indicate its source going forward.

[github-actions]

Checkmarx One – Scan Summary & Details – 1a46ceff-9961-45c3-a97c-5061481ccd48

No New Or Fixed Issues Found

[SaintPatrck]

Also relates to PM-13101

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (0c83a10) to head (b01aa5e).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4005   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         425      425           
  Lines       35098    35098           
  Branches     5143     5143           
=======================================
  Hits        31196    31196           
  Misses       2108     2108           
  Partials     1794     1794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.