[PM-12322] Remove branch restriction for distributing to Firebase #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
SaintPatrck
force-pushed
the
workflow/ditribute-from-any-branch
branch
from
b115101
to
57d61ee
Compare
The previous workflow only distributed artifacts when the branch was 'main'. This change removes that restriction, allowing artifacts to be distributed from any branch.
SaintPatrck
force-pushed
the
workflow/ditribute-from-any-branch
branch
from
57d61ee
to
6a2c261
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 425 425
Lines 35033 35033
Branches 5134 5134
=======================================
Hits 31131 31131
Misses 2110 2110
Partials 1792 1792 ☔ View full report in Codecov by Sentry. |
david-livefront
approved these changes
Sep 30, 2024
fedemkr
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12322
📔 Objective
The previous workflow only distributed artifacts when the branch was
main. This change removes that restriction, allowing artifacts to be distributed from any branch.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes