PM-11485: Add routing logic to handle searching during accessibility autofill #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3924 +/- ##
==========================================
- Coverage 88.67% 88.67% -0.01%
==========================================
Files 420 420
Lines 34180 34184 +4
Branches 5048 5049 +1
==========================================
+ Hits 30310 30313 +3
Misses 2099 2099
- Partials 1771 1772 +1 ☔ View full report in Codecov by Sentry. |
david-livefront
force-pushed
the
PM-11485-accessibility-search-route
branch
from
bd95710
to
d7c1070
Compare
david-livefront
force-pushed
the
PM-11485-accessibility-search-route
branch
from
d7c1070
to
7785bde
Compare
| @@ -622,6 +625,20 @@ class SearchViewModel @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| private fun useCipherForAutofill(cipherView: CipherView) { | |||
|
Thanks @dseverns-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11485
📔 Objective
This PR adds additional routing logic for accessibility-base autofill in the app. This new logic supports searching for a cipher when using accessibility autofill.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes