Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-11487: Initial accessibility service and processor for handling autofill #3906

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Sep 11, 2024

🎟️ Tracking

PM-11487

📔 Objective

This PR adds the BitwardenAccessibilityService and BitwardenAccessibilityProcessor for handling autofill vial accessibility.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Logo
Checkmarx One – Scan Summary & Detailse30a3edf-2f11-4937-bf91-9b033ae4f648

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (537c501) to head (80735df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3906      +/-   ##
==========================================
+ Coverage   88.67%   88.69%   +0.01%     
==========================================
  Files         416      418       +2     
  Lines       33987    34047      +60     
  Branches     5011     5024      +13     
==========================================
+ Hits        30138    30198      +60     
  Misses       2091     2091              
  Partials     1758     1758              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront merged commit 4c1d55e into main Sep 12, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-11487-accessibility-service branch September 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants