Use an aar to define bridge dependency #3892
Conversation
ahaisting-livefront
requested review from
SaintPatrck,
david-livefront,
brian-livefront and
dseverns-livefront
app/build.gradle.kts
Outdated
| // TODO: this should use a versioned aar instead of referencing the project BITAU-94 | ||
| implementation(project(":bridge")) | ||
| // TODO: this should use a versioned aar instead of referencing a local aar BITAU-94 | ||
| implementation(files("libs/bridge-release.aar")) |
There was a problem hiding this comment.
Can we at least give this some kind of version or "snapshot" kind of name? Maybe 0.1.0-snapshot to make clear its not actually released?
There was a problem hiding this comment.
Yup, totally fair.
I'm going to look into including that automatically on the bridge build side. I'm assuming that's what you mean.
There was a problem hiding this comment.
Just force pushed an update that adds the version to the output .aar to help reduce confusion until we can get a permanent solution.
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3892 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 411 411
Lines 33768 33768
Branches 4988 4988
=======================================
Hits 29923 29923
Misses 2091 2091
Partials 1754 1754 ☔ View full report in Codecov by Sentry. |
- Add build instructions to bridge README
ahaisting-livefront
force-pushed
the
use-aar
branch
from
c70f8f8
to
066b2c4
Compare
bridge/README.md
Outdated
| @@ -16,6 +17,14 @@ | |||
| - **Minimum SDK**: 28 | |||
| - **Target SDK**: 34 | |||
|
|
|||
| ## Building | |||
|
|
|||
| To build an aar for inclusion in consumer applications, run: | |||
There was a problem hiding this comment.
aar should be AAR anywhere we refer to it.
There was a problem hiding this comment.
Cool 👍
app/build.gradle.kts
Outdated
| // TODO: this should use a versioned aar instead of referencing the project BITAU-94 | ||
| implementation(project(":bridge")) | ||
| // TODO: this should use a versioned aar instead of referencing a local aar BITAU-94 | ||
| implementation(files("libs/bridge-0.1.0-release.aar")) |
There was a problem hiding this comment.
I'm still wondering if we should slap snapshot on here manually to make clear this isn't the released version of 0.1.0.
There was a problem hiding this comment.
I'll defer to you!
Our definition of released is pretty nebulous. If its built and included in the source of the Bitwarden app, isn't it released?
I'm happy either way.
There was a problem hiding this comment.
I went ahead and added SNAPSHOT:
|
Thanks for the comments, @brian-livefront ! |
📔 Objective
The goal here is to fix the failing
betavariants onmain. When definingbridgeas aprojectdependency, a variant forbetacannot be found. Including an.aaras the dependency resolves this issue.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes