BITAU-102 Return null BridgeService when API level is below 12 #3887
Conversation
ahaisting-livefront
requested review from
SaintPatrck,
david-livefront,
brian-livefront and
dseverns-livefront
|
No New Or Fixed Issues Found |
ahaisting-livefront
force-pushed
the
bridge-block-below-android-12
branch
from
0c932b4
to
570e94d
Compare
| return if ( | ||
| !featureFlagManager.getFeatureFlag(FlagKey.AuthenticatorSync) || | ||
| isBuildVersionBelow(Build.VERSION_CODES.S) | ||
| ) { | ||
| // If the feature flag is not enabled, OR if version is below Android 12, | ||
| // return a null binder which will no-op all service calls | ||
| null | ||
| } else { | ||
| // Otherwise, return real binder implementation: | ||
| defaultBinder |
There was a problem hiding this comment.
I swapped the order of this condition to try to make it more readable... let me know what y'all think!
This reads nice to me, but I know if statement readability can be quite subjective.
There was a problem hiding this comment.
Could also do a takeUnless too. But this is also fine.
There was a problem hiding this comment.
Either way is an improvement. I don't feel too strongly one way or the other.
ahaisting-livefront
force-pushed
the
bridge-block-below-android-12
branch
from
570e94d
to
b5e9bb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3887 +/- ##
==========================================
- Coverage 88.61% 88.60% -0.01%
==========================================
Files 411 411
Lines 33763 33765 +2
Branches 4987 4988 +1
==========================================
+ Hits 29918 29919 +1
- Misses 2091 2092 +1
Partials 1754 1754 ☔ View full report in Codecov by Sentry. |
|
Thanks, @brian-livefront and @SaintPatrck ! |
🎟️ Tracking
https://livefront.atlassian.net/browse/BITAU-102
📔 Objective
Make sure we no-op all
BridgeServicecalls under android API level 12.📸 Screenshots
N/A
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes