Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate the accessibility package into the autofill package #3860

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR contain no functional changes and simply moves the accessibility package into the autofill package for better organization moving forward.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Logo
Checkmarx One – Scan Summary & Details0064be5d-8aa8-4c53-900a-17f43132f272

No New Or Fixed Issues Found

@david-livefront
Copy link
Collaborator Author

Thanks @brian-livefront

@david-livefront david-livefront merged commit e3a4a7b into main Sep 4, 2024
7 checks passed
@david-livefront david-livefront deleted the move-accessibility-package branch September 4, 2024 16:30
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (36f13e4) to head (63bb03e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3860   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         404      404           
  Lines       33256    33256           
  Branches     4905     4905           
=======================================
  Hits        29385    29385           
  Misses       2144     2144           
  Partials     1727     1727           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants