Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10686] Change the background colour of the app launcher to Bitwarden's blue #3693

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

vvolkgang
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-10686

๐Ÿ“” Objective

Change the app launcher background colour to Bitwarden blue when devices are using the Dark theme. Can be tested with builds from run/10282330788.

๐Ÿ“ธ Screenshots

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ cff631b4-3d6e-4cac-919b-034884caad61

No New Or Fixed Issues Found

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 87.82%. Comparing base (59ba585) to head (e867ebb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3693   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         368      368           
  Lines       30546    30546           
  Branches     4576     4576           
=======================================
  Hits        26828    26828           
  Misses       2121     2121           
  Partials     1597     1597           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@vvolkgang vvolkgang merged commit d8471b4 into main Aug 7, 2024
15 checks passed
@vvolkgang vvolkgang deleted the launcher-colour branch August 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants