Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-10241: Add the onboarding carousel feature flag #3686

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Aug 6, 2024

🎟️ Tracking

PM-10241

📔 Objective

This PR adds a feature flag for the Onboarding Carousel feature flag.

Note that the flag is not yet used in this PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront marked this pull request as ready for review August 6, 2024 15:05
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Logo
Checkmarx One – Scan Summary & Details33a01a64-33ae-41eb-8c52-6fdb60d1b65e

No New Or Fixed Issues Found

Copy link
Collaborator

@shannon-livefront shannon-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 ❤️

@david-livefront
Copy link
Collaborator Author

Thanks @shannon-livefront

@david-livefront david-livefront merged commit 3819916 into main Aug 6, 2024
7 checks passed
@david-livefront david-livefront deleted the PM-10241-onboarding-carousel-flag branch August 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants