Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null network responses for 204s #3685

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Aug 6, 2024

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

This PR updates the ResultCall class to allow for 204 responses that are nullable classes instead of Unit.

Ideally we could determine if the successType is a nullable value and allow null based on that but unfortunately the information is not available to us.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@david-livefront david-livefront marked this pull request as ready for review August 6, 2024 14:56
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 3f5cf4b5-902f-4926-9221-1342d18a4b91

No New Or Fixed Issues Found

@david-livefront
Copy link
Collaborator Author

Thanks @brian-livefront

@david-livefront david-livefront merged commit e7c69fc into main Aug 6, 2024
7 checks passed
@david-livefront david-livefront deleted the null-network-responses branch August 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants