Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-10122: Autofocus on PIN or password field #3678

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

shannon-livefront
Copy link
Collaborator

@shannon-livefront shannon-livefront commented Aug 5, 2024

🎟️ Tracking

PM-10122

📔 Objective

Auto focus on the PIN or password entry fields when unlocking the vault or logging in.

📸 Screenshots

Logging in:

Before After
10122.before.1.mov
10122.after.1.mov

Unlocking the vault:

Before After
10122.before.2.mov
10122.after.2.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Logo
Checkmarx One – Scan Summary & Detailsfe954a41-fc50-4354-bdd0-22865e9f1eb3

No New Or Fixed Issues Found

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (4c81649) to head (68e80b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3678   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files         368      368           
  Lines       30481    30483    +2     
  Branches     4557     4557           
=======================================
+ Hits        26764    26766    +2     
  Misses       2128     2128           
  Partials     1589     1589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SaintPatrck SaintPatrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Unless I'm missing something, I believe this is addressing the same issue as #3601. @qwexter's changes respect biometrics and also prevent UnlockClick from processing if the input field is empty. Thoughts on using their changes and closing this PR?

@shannon-livefront
Copy link
Collaborator Author

🤔 Unless I'm missing something, I believe this is addressing the same issue as #3601. @qwexter's changes respect biometrics and also prevent UnlockClick from processing if the input field is empty. Thoughts on using their changes and closing this PR?

🫠 I'm glad you told me about that, thank you! I'm good with closing this PR

@SaintPatrck
Copy link
Contributor

@shannon-livefront #3601 does not fix the issue on LoginScreen. Let's leave this PR open, but reduce the scope to focus on LoginScreen changes.

Also, I agree with @david-livefront and @dseverns-livefront that we should give biometrics precedence over password/pin field focus. This is how the MAUI app behaves, as well.

@shannon-livefront shannon-livefront force-pushed the PM-10122-autofocus-pin-password-field branch from 68e80b7 to c817952 Compare August 6, 2024 19:31
@shannon-livefront shannon-livefront merged commit 59ba585 into main Aug 6, 2024
7 checks passed
@shannon-livefront shannon-livefront deleted the PM-10122-autofocus-pin-password-field branch August 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants