-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-10122: Autofocus on PIN or password field #3678
Conversation
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3678 +/- ##
=======================================
Coverage 87.80% 87.80%
=======================================
Files 368 368
Lines 30481 30483 +2
Branches 4557 4557
=======================================
+ Hits 26764 26766 +2
Misses 2128 2128
Partials 1589 1589 ☔ View full report in Codecov by Sentry. |
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫠 I'm glad you told me about that, thank you! I'm good with closing this PR |
@shannon-livefront #3601 does not fix the issue on LoginScreen. Let's leave this PR open, but reduce the scope to focus on LoginScreen changes. Also, I agree with @david-livefront and @dseverns-livefront that we should give biometrics precedence over password/pin field focus. This is how the MAUI app behaves, as well. |
68e80b7
to
c817952
Compare
🎟️ Tracking
PM-10122
📔 Objective
Auto focus on the PIN or password entry fields when unlocking the vault or logging in.
📸 Screenshots
Logging in:
10122.before.1.mov
10122.after.1.mov
Unlocking the vault:
10122.before.2.mov
10122.after.2.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes