Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10440] Enable minification on beta build variants #3661

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-10440

📔 Objective

This pull requests fixes the size difference between beta and release variants by enabling minification on beta build variants.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck changed the title Enable minification on beta build variants [PM-10440] Enable minification on beta build variants Jul 31, 2024
vvolkgang
vvolkgang previously approved these changes Jul 31, 2024
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n🧊

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Logo
Checkmarx One – Scan Summary & Details8344b95d-00f5-4eb7-aab1-ff4e21a7793b

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (260b3bf) to head (482d15a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3661   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files         368      368           
  Lines       30457    30457           
  Branches     4550     4550           
=======================================
  Hits        26744    26744           
  Misses       2129     2129           
  Partials     1584     1584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck enabled auto-merge (squash) July 31, 2024 22:18
@SaintPatrck SaintPatrck merged commit d558f94 into main Jul 31, 2024
9 checks passed
@SaintPatrck SaintPatrck deleted the fix-build-artifact-size-difference branch July 31, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants