Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10373] Fix FIDO 2 credential creation from unprivileged apps #3658

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-10373

📔 Objective

This pull request fixes incorrect arguments passed to Bitwarden SDK when handling passkey registration and authentication requests from unprivileged applications.

When registering a passkey from an unprivileged application, Bitwarden SDK expects ClientData.DefaultWithExtraData.androidPackageName to be the calling application package name. However, during authentication ClientData.DefaultWithExtraData.androidPackageName is the apk-key-hash.

Bitwarden SDK requires origin to be a valid HTTP URL, including the protocol preamble, when performing registration and authentication.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Logo
Checkmarx One – Scan Summary & Details4fff3d0e-43fa-4d74-bda6-55037ec78075

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.79%. Comparing base (646566e) to head (6ce5f85).
Report is 6 commits behind head on main.

Files Patch % Lines
...tofill/fido2/manager/Fido2CredentialManagerImpl.kt 86.95% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3658      +/-   ##
==========================================
- Coverage   87.79%   87.79%   -0.01%     
==========================================
  Files         368      368              
  Lines       30459    30472      +13     
  Branches     4547     4552       +5     
==========================================
+ Hits        26742    26752      +10     
  Misses       2130     2130              
- Partials     1587     1590       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck enabled auto-merge (squash) August 2, 2024 14:23
@SaintPatrck SaintPatrck merged commit 31bf696 into main Aug 5, 2024
9 checks passed
@SaintPatrck SaintPatrck deleted the PM-10373/create-passkey-from-android-apps branch August 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants