-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-10242 PM-10243 PM-10244 PM-10245 PM-10246: Welcome carousel #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannon-livefront
requested review from
david-livefront,
SaintPatrck and
dseverns-livefront
July 31, 2024 17:01
No New Or Fixed Issues Found |
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 1, 2024 18:04
74d261a
to
076a350
Compare
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt
Outdated
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 5, 2024 19:30
076a350
to
d21c0e6
Compare
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 5, 2024 21:39
d21c0e6
to
b326ae3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
==========================================
+ Coverage 87.82% 87.85% +0.03%
==========================================
Files 368 370 +2
Lines 30535 30732 +197
Branches 4577 4592 +15
==========================================
+ Hits 26817 27000 +183
- Misses 2121 2132 +11
- Partials 1597 1600 +3 ☔ View full report in Codecov by Sentry. |
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 6, 2024 14:02
b326ae3
to
c3161a1
Compare
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt
Outdated
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 6, 2024 18:56
c3161a1
to
fb3f205
Compare
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt
Outdated
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 6, 2024 19:51
fb3f205
to
a856f00
Compare
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 7, 2024 15:33
d087c5f
to
e8b863c
Compare
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
2 times, most recently
from
August 7, 2024 15:57
87cdfd7
to
1b62e97
Compare
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt
Show resolved
Hide resolved
SaintPatrck
reviewed
Aug 7, 2024
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt
Show resolved
Hide resolved
shannon-livefront
force-pushed
the
PM-10242-welcome-carousel
branch
from
August 7, 2024 19:40
d34a202
to
61c5bdb
Compare
SaintPatrck
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-10242
PM-10243
PM-10244
PM-10245
PM-10246
📔 Objective
Add a new welcome carousel before the landing page for users who are opening the app for the first time (ie, who have never logged in or created an account on the device before)
NOTE: For now, the old landing page and create account views are shown, just to make sure the buttons work. It looks a little strange, but the auth flow will be updated more in later tickets.
📸 Screenshots
before.mov
after.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes