Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-10242 PM-10243 PM-10244 PM-10245 PM-10246: Welcome carousel #3657

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

shannon-livefront
Copy link
Collaborator

@shannon-livefront shannon-livefront commented Jul 31, 2024

🎟️ Tracking

PM-10242
PM-10243
PM-10244
PM-10245
PM-10246

📔 Objective

Add a new welcome carousel before the landing page for users who are opening the app for the first time (ie, who have never logged in or created an account on the device before)

NOTE: For now, the old landing page and create account views are shown, just to make sure the buttons work. It looks a little strange, but the auth flow will be updated more in later tickets.

📸 Screenshots

Before After
before.mov
after.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Logo
Checkmarx One – Scan Summary & Details16e00d5b-4779-44c9-b738-661bc402bd88

No New Or Fixed Issues Found

@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from 74d261a to 076a350 Compare August 1, 2024 18:04
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from 076a350 to d21c0e6 Compare August 5, 2024 19:30
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from d21c0e6 to b326ae3 Compare August 5, 2024 21:39
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 92.92929% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.85%. Comparing base (be534f9) to head (27f33bf).
Report is 1 commits behind head on main.

Files Patch % Lines
...bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt 93.89% 5 Missing and 3 partials ⚠️
...warden/ui/auth/feature/welcome/WelcomeViewModel.kt 90.90% 5 Missing ⚠️
...en/ui/platform/feature/rootnav/RootNavViewModel.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
+ Coverage   87.82%   87.85%   +0.03%     
==========================================
  Files         368      370       +2     
  Lines       30535    30732     +197     
  Branches     4577     4592      +15     
==========================================
+ Hits        26817    27000     +183     
- Misses       2121     2132      +11     
- Partials     1597     1600       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from b326ae3 to c3161a1 Compare August 6, 2024 14:02
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from c3161a1 to fb3f205 Compare August 6, 2024 18:56
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from fb3f205 to a856f00 Compare August 6, 2024 19:51
@shannon-livefront shannon-livefront marked this pull request as ready for review August 6, 2024 19:51
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from d087c5f to e8b863c Compare August 7, 2024 15:33
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch 2 times, most recently from 87cdfd7 to 1b62e97 Compare August 7, 2024 15:57
@shannon-livefront shannon-livefront force-pushed the PM-10242-welcome-carousel branch from d34a202 to 61c5bdb Compare August 7, 2024 19:40
@shannon-livefront shannon-livefront merged commit f17289a into main Aug 7, 2024
9 checks passed
@shannon-livefront shannon-livefront deleted the PM-10242-welcome-carousel branch August 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants