BIT-2398 if the org associated with a cipher uses TOTP enable the aut…

[dseverns-livefront]

🎟️ Tracking

BIT-2398

📔 Objective

When there are features around TOTP, in addition to having premium, accounts which have a cipher which had TOTP enabled by an Org. should also be considered

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – b8adbb75-87bc-48ec-8d7b-65e3162362a5

Fixed Issues

Severity	Issue	Source File / Package
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 361
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 679
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 679
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 679
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 581
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 679
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 679

[dseverns-livefront]

Note This is the iOS PR for similar ticket, the changes there looks a lot close to the legacy app. I took this to be the way we are storing and retrieving the ciphers from disk. This was the only area where I found isPremium considered along with a TOTP feature.

[codecov]

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (9e0e079) to head (5afbe3c).

Files	Patch %	Lines
...ture/verificationcode/VerificationCodeViewModel.kt	77.77%	0 Missing and 2 partials ⚠️
...ui/vault/feature/vault/util/VaultDataExtensions.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3398   +/-   ##
=======================================
  Coverage   85.48%   85.49%           
=======================================
  Files         357      357           
  Lines       29090    29104   +14     
  Branches     5064     5070    +6     
=======================================
+ Hits        24869    24882   +13     
  Misses       2164     2164           
- Partials     2057     2058    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.