Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9151] gradle: Fix typo for Robolectric library name #3338

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Jun 22, 2024

roboelectric -> robolectric

🎟️ Tracking

Just fixing a simple typo in gradle dependency file.

📔 Objective

Just fixing a simple typo in gradle dependency file.

📸 Screenshots

None.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2024

CLA assistant check
All committers have signed the CLA.

@djsmith85 djsmith85 requested a review from a team June 22, 2024 22:28
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-9151

@bitwarden-bot bitwarden-bot changed the title gradle: Fix typo for Robolectric library name [PM-9151] gradle: Fix typo for Robolectric library name Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Logo
Checkmarx One – Scan Summary & Detailsb2dae5d6-166a-49dd-9376-7c0a371e0b12

No New Or Fixed Issues Found

roboelectric -> robolectric

Signed-off-by: utzcoz <[email protected]>
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (96b4326) to head (2cf50aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3338   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         356      356           
  Lines       28903    28903           
  Branches     4998     4998           
=======================================
  Hits        24765    24765           
  Misses       2119     2119           
  Partials     2019     2019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck merged commit 2720a80 into bitwarden:main Jun 27, 2024
9 checks passed
@utzcoz utzcoz deleted the fix-robolectric-typo branch June 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants