Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GthTx as assumed domain diff domain #605

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

martijnbastiaan
Copy link
Contributor

@martijnbastiaan martijnbastiaan commented Aug 14, 2024

Fixes #604
Fixes #608

I'll admit that this isn't exactly the prettiest PR. I plan to clean up all the juggling in #609.

TODO

@martijnbastiaan martijnbastiaan force-pushed the clock-discrapencies-fix604 branch 3 times, most recently from 79cfe2b to 0de395a Compare August 19, 2024 11:45
@martijnbastiaan martijnbastiaan force-pushed the clock-discrapencies-fix604 branch 3 times, most recently from 88c20a5 to 54a7c53 Compare August 20, 2024 14:50
@martijnbastiaan martijnbastiaan linked an issue Aug 20, 2024 that may be closed by this pull request
@martijnbastiaan martijnbastiaan force-pushed the clock-discrapencies-fix604 branch from 54a7c53 to 68e51ec Compare August 20, 2024 15:28
@martijnbastiaan martijnbastiaan marked this pull request as ready for review August 20, 2024 15:29
@martijnbastiaan martijnbastiaan added the 2 Review/merge second label Aug 20, 2024
@martijnbastiaan martijnbastiaan force-pushed the clock-discrapencies-fix604 branch 2 times, most recently from f8a947f to ab23ec5 Compare August 20, 2024 17:55
@martijnbastiaan martijnbastiaan force-pushed the clock-discrapencies-fix604 branch from ab23ec5 to 923297b Compare August 21, 2024 08:50
@martijnbastiaan martijnbastiaan added 1 Review/merge first and removed 2 Review/merge second labels Aug 21, 2024
@martijnbastiaan martijnbastiaan merged commit d62ed31 into staging Aug 21, 2024
30 checks passed
@martijnbastiaan martijnbastiaan deleted the clock-discrapencies-fix604 branch August 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Review/merge first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock reports flip sign of clock offsets Discrepancies between clock plots and clock offsets
2 participants