Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-axis of clock plots should be shifted according to clock offsets #607

Closed
martijnbastiaan opened this issue Aug 15, 2024 · 0 comments · Fixed by #610
Closed

Y-axis of clock plots should be shifted according to clock offsets #607

martijnbastiaan opened this issue Aug 15, 2024 · 0 comments · Fixed by #610
Labels
enhancement New feature or request

Comments

@martijnbastiaan
Copy link
Contributor

martijnbastiaan commented Aug 15, 2024

It's currently hard to interpret the clock plots as they are relative to the measurement clock, which is (IMO) the main reason #604 has been able to go unnoticed for multiple months. I propose assuming one of the clock offsets is correct, and shifting the y-axis until it is set in its "proper" place.

E.g., this (example plots still affected by #606):

Screenshot from 2024-08-14 18-59-38

Should be approximately:

357921514-d9728c08-6657-4511-aaba-63d3e40956b6

Should also be mentioned in #603

We should probably also be able to generate "debug" plots, where we show the position of the reference clock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant