Removed register_attr from required rust features when compiling for spirv #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I took the liberty of removing the
register_attr
feature since it's no longer supported on Rust nightly since September 2022. It doesn't seem that the feature is actively being used anywhere in theglam
codebase.I'm working on
rust-gpu
, which requires the Rust nightly toolchain and am in the process to update to a more recent nightly toolchain. Since one of our crates,spirv-std
, is optionally dependent onglam
, I'm getting compile errors because of thefeature(register_attr)
.