Change type from int to string #39
Conversation
| @@ -138,7 +138,7 @@ func updateVersionNumbersInInfoPlist(helper *projectmanager.ProjectHelper, targe | |||
| absoluteInfoPlistPath := filepath.Join(filepath.Dir(helper.XcProj.Path), infoPlistPath) | |||
|
|
|||
| infoPlist, format, _ := xcodeproj.ReadPlistFile(absoluteInfoPlistPath) | |||
| infoPlist["CFBundleVersion"] = bundleVersion | |||
| infoPlist["CFBundleVersion"] = strconv.Itoa(bundleVersion) | |||
There was a problem hiding this comment.
Hey, my builds are currently failing on CI. by bundle version is 7.20.0 which I believe would fail strconv.Itoa. What was the need for this change? Cheers
There was a problem hiding this comment.
./prog.go:11:27: cannot use "7.20.0" (untyped string constant) as int value in argument to strconv.Itoa
There was a problem hiding this comment.
Same here. What was the need for this update?
There was a problem hiding this comment.
While I agree that Apple considers CFBundleVersion to be in format X.Y.Z, in Bitrise docs there are multiple mentions that build numbers should be plain integers and not in format X.Y.Z.
Unless I'm mistaken, adopting this step in Bitrise implies to convert your CFBundleVersion to a plain integer.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
The type of the bundle version has to be string instead of integer.