Minimal setup flag #944
Merged
Minimal setup flag #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Apr 12, 2024
ofalvai
commented
Apr 12, 2024
godrei
reviewed
Apr 12, 2024
godrei
reviewed
Apr 12, 2024
godrei
approved these changes
Apr 12, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
bitrise setupis triggered automatically when the CLI is upgraded to a newer version. This setup does a lot of things that are not necessary in CI, such as installing plugins meant for local work.Changes
--minimalflag to the setup subcommand that skips installing plugins,stepman, and skips the system check on macOS--fullsetup flag. This controlled only one thing, runningbrew doctorwhen running on macOSInvestigation details
Timing tests on my local machine:
Old worst case: all plugins are older than the minimum versions defined by the new CLI: 20s
Old best case: 574ms
New minimal flag: 328ms
Decisions