Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pull request comment #937

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Conversation

trapacska
Copy link
Collaborator

@trapacska trapacska commented Apr 8, 2024

Checklist

Version

Requires a MINOR version update

Context

Resolves: https://bitrise.atlassian.net/browse/BIVS-2527

Changes

This PR updates the bitrise.yml data model to support advanced trigger map features:

New fields introduced on the Trigger Map items:

  • These originally was introduced for Code Push Items and can be reused for PRs:

    • commit_message
    • changed_files
  • For Pull Request Items:

    • pull_request_comment

The evaluation of these items (trigger check) has been moved to another Bitrise component, for now the original trigger check functionality is kept here intact and will be removed in the future.

@trapacska trapacska marked this pull request as ready for review April 8, 2024 16:50
@trapacska trapacska requested a review from godrei April 9, 2024 08:33
godrei
godrei previously approved these changes Apr 9, 2024
Copy link
Contributor

@molnarm molnarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See unresolved comments. Also, there are no tests checking that validation.

@godrei godrei merged commit 8de0204 into master Apr 18, 2024
5 checks passed
@godrei godrei deleted the BIVS-2527-iteration-2-cli-model-changes branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants