Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of step output writers #851

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Feb 1, 2023

Checklist

Version

Requires a PATCH version update

Context

This PR fixes the issue that Bitrise CLI wasn't redacting secrets in the step failure reasons.
The root cause of the issue was, that the step error finder logic was running before the secret redaction logic.

Changes

  • Change the order of errorfinder and filterwriter in the Step output writer chain

Investigation details

Decisions

@godrei godrei marked this pull request as ready for review February 2, 2023 10:17
@godrei godrei requested a review from tothszabi February 2, 2023 10:47
@tothszabi tothszabi merged commit 8b49b76 into master Feb 2, 2023
@tothszabi tothszabi deleted the step-output-writers branch February 2, 2023 15:30
@tothszabi tothszabi mentioned this pull request Feb 2, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants