Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.md
is updated with the changes (if needed)Version
Requires a PATCH version update
Context
This PR fixes a bug with structured logging: before Bitrise CLI installs an apt-get package, an apt-get update command is executed, which was writing to the os.Stdout directly. This resulted in a raw log, even if structured logging was enabled (
--output-format json
)Changes
Investigation details
I was searching for
os.Stdout
andos.Stderr
in the codebase to find all the occurrences where we write directly to the standard output.