-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove leftover log level handlings #824
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
759ba3c
Remove leftover log level handlings
godrei d1b921e
Merge branch 'master' into remove-log-level-flag-handling
godrei ecb3497
Improve and test loggerParameters func
godrei 5ab44f2
Specify debug loglevel for stepman and envman commands
godrei 8a99871
Revert specifying loglevel flag for envman and stepman commands
godrei 643c44a
loggerParameters function cleanup
godrei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user can set the debug mode in two ways:
The stepman process inherits the envs from the parent process so if the user used the debug env key then stepman can also print the debug logs.
But if the user used the command line parameters then the cli will print debug logs but stepman will not because we are not passing the loglevel anymore.
I do not know yet how useful the stepman debug logs are so I am also happy to remove this. But if we want consistency then I would add the
--loglevel debug
parameter to stepman in the case if we are running in a debug mode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated my PR to restore the original behaviour around debug mode.
Now envan and stepman inherits Bitrise CLIs debug mode, this involved 2 main changes:
LOGLEVEL=debug
env varSpecifying
--loglevel=debug
flag for the envman and stepman commands is not needed because the LOGLEVEL env var controls the log level flag for both stepman and envman.On the other side, specifying
--loglevel=debug
in itself is not enough, because this way we restore the behavior for wrapped commands of envman and stepman, but not for the envman and stepman plugin commands:bitrise -debug stepman share audit
bitrise -debug share audit