-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Envman functions #819
Envman functions #819
Conversation
f1036b4
to
104e42a
Compare
cmd.SetTimeout(timeout) | ||
cmd.SetHangTimeout(noOutputTimeout) | ||
cmd.SetStandardIO(inReader, outWriter, errWriter) | ||
cmd.AppendEnv("PWD=" + workDirPth) | ||
cmd.SetEnv(append(envs, "PWD="+workDirPth)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this better than the existing AppendEnv()
call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppendEnv
is working with a single environment variable + checking if the command has Env set or not is unnecessary because it will always be nil, and the envs we set already contain the os.Environ.
Although we don't need both functions, so I removed cmd.AppendEnv
in 73afe9d
Checklist
README.md
is updated with the changes (if needed)Version
Requires a MINOR version update
Context
This PR makes Bitrise CLI use envman functionalities through exported functions rather than through envman binary calls.
Changes
tools.Envman<Function>s
to use envman exported functions.Investigation details
Decisions