Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golangci-lint #808

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Use golangci-lint #808

merged 3 commits into from
Aug 1, 2022

Conversation

lpusok
Copy link
Contributor

@lpusok lpusok commented Aug 1, 2022

Context

Fetching errcheck and golint (also deprecated) timed out due to problems with the Google Go module proxy.
Switching to golangci-lint, which runs errcheck by default and a few other alternatives to golint (staticcheck).
Ignoring existing issues, see .golangci.yml.

@lpusok lpusok requested review from ofalvai and hisaac August 1, 2022 16:10
Copy link
Contributor

@hisaac hisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@lpusok lpusok merged commit 3469eb0 into master Aug 1, 2022
@lpusok lpusok deleted the BE-170-CI-fix branch August 1, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants