Remove Xcode dependency check #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Jun 30, 2022
go.mod
Outdated
| @@ -3,31 +3,19 @@ module github.com/bitrise-io/bitrise | |||
| go 1.16 | |||
|
|
|||
| require ( | |||
| github.com/Masterminds/semver v1.5.0 // indirect | |||
There was a problem hiding this comment.
There are so many changed lines because I ran go mod tidy on the project.
tothszabi
previously approved these changes
Jun 30, 2022
tothszabi
previously approved these changes
Jun 30, 2022
|
Documentation says that only xcode is supported, but in fact there seems to be also the code supporting anything else. So the check only dependency feature is really usable for any tool. Shouldn't only support for the special case |
tothszabi
approved these changes
Jul 19, 2022
This was referenced Aug 2, 2022
This was referenced Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Xcode dependency check from the step.yml model. We consider this an unnecessary check nowadays as the Bitrise VMs definitely have Xcode installed and expect local environments to have it installed too.