Update version #1021
Merged
Update version #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
reviewed
Nov 13, 2024
| @@ -660,7 +660,7 @@ workflows: | |||
|
|
|||
| warns, err := config.Validate() | |||
| if len(tt.wantWarns) > 0 { | |||
| require.Equal(t, tt.wantWarns, warns) | |||
| require.ElementsMatch(t, tt.wantWarns, warns) | |||
There was a problem hiding this comment.
Yep. All the test cases used a single item array so the Equal was fine. I added a new test case with two items and the original PR was green. Merged it and found out that you should not use Equal to compare arrays. 😄
ofalvai
approved these changes
Nov 13, 2024
godrei
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
The pipeline validation got tweaked a bit and will go out in this CLI version.