[CI-3190] Improve parameter logging #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
force-pushed
the
CI-3190-improve-parameter-logging
branch
from
bdf8a15
to
9860ff8
Compare
godrei
reviewed
Sep 10, 2024
godrei
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
The previous command line parser was not handling all the edge cases and was logging incorrect data. For example, us and the users are calling the CLI with not a fix parameter type order.
In this iteration I am relying on the
urfave/clipackage to get access to the parameter list. It already knows the correct parameters for a given command / subcommand so by the time the action starts we can have access to a correct parameter list.