Skip to content

Commit

Permalink
Observe --noexperimental_check_output_files even for run commands.
Browse files Browse the repository at this point in the history
This reverts the functional changes introduced by bazelbuild@2f899ef. They're no longer required because bazelbuild@4c42edb also happened to fix incremental fetching of top-level outputs for `run` commands. The integration test added by the former CL remains in place.

Fixes bazelbuild#20843.

PiperOrigin-RevId: 693664834
Change-Id: I64c1b0d14ae54f3906b9f7d916dbbb4f0204a1b9
  • Loading branch information
tjgq authored and ramil-bitrise committed Dec 18, 2024
1 parent b50550e commit 78345a4
Showing 1 changed file with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -520,12 +520,9 @@ private ModifiedFileSet startBuildAndDetermineModifiedOutputFiles(
informedOutputServiceToStartTheBuild = true;
}
if (!request.getPackageOptions().checkOutputFiles) {
// Do not skip output invalidation in the following cases:
// 1. If the output tree is empty: this can happen after it's cleaned or corrupted.
// 2. For a run command: so that outputs are downloaded even if they were previously built
// with --remote_download_minimal. See https://github.com/bazelbuild/bazel/issues/20843.
if (!modifiedOutputFiles.treatEverythingAsDeleted()
&& !request.getCommandName().equals("run")) {
// Do not skip output invalidation if the output tree is empty: this can happen after it's
// cleaned or corrupted.
if (!modifiedOutputFiles.treatEverythingAsDeleted()) {
return ModifiedFileSet.NOTHING_MODIFIED;
}
}
Expand Down

0 comments on commit 78345a4

Please sign in to comment.