Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize metrics collector args #457

Merged

Conversation

stankevich
Copy link
Contributor

@stankevich stankevich commented Jan 28, 2020

Allows passing extra args to the metrics exporter via the cluster spec to e.g. enable/configure additional metrics collectors.

Example:

---
apiVersion: mysql.presslabs.org/v1alpha1
kind: MysqlCluster
metadata:
  name: example
spec:
  # [...]
  metricsExporterExtraArgs:
    - --collect.info_schema.userstats
    - --collect.perf_schema.file_events
  # [...]

Allows passing extra args to metrics exporter to e.g. enable/configure
additional metrics collectors.
@stankevich stankevich force-pushed the parameterize-metrics-exporter-flags branch from 8682bf7 to 2b3567d Compare January 30, 2020 20:01
@stankevich stankevich changed the title Parameterize metrics collector flags Parameterize metrics collector args Jan 30, 2020
@stankevich
Copy link
Contributor Author

stankevich commented Jan 30, 2020

I just force-pushed a change that renames metricsExporterFlags into metricsExporterExtraArgs to keep the naming scheme consistent with the updates I'm currently working on for #437 (e.g. xbstreamExtraArgs, will PR soon). Updated the title and the description here as well.

Thanks!

@AMecea AMecea merged commit 6348062 into bitpoke:master Feb 11, 2020
@stankevich stankevich deleted the parameterize-metrics-exporter-flags branch February 11, 2020 22:02
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants