remove hook to be helm3 compatible, change crd generation, move to crds directory

[21h]

crd hook not supported in helm3, tested installation without this hook and all works fine.

[AMecea]

Hi @21h, thank you for opening this PR!

This will brake helm 2 compatibility. My suggestion is to do as guys from Prometheus operator did. Doing so will be backward compatible.

Those files are generated, so you have to change the script that updates them. See this file.

[21h]

@AMecea checkout files, I made changes you requested

[AMecea]

Thank you @21h !

It's almost done, you have to add a file template/crd.yaml which will include the CRDs for helm version 2. See this code.

[AMecea]

the annotations helm,sh/hook=crd-install should be kept to be backward compatible.

[AMecea]

I suggest keeping this label to a hardcoded value: app=mysql-operator

[AMecea]

Also, please update the chart README.md and also bump chart version, see #445

[AMecea]

ping @21h 😄

[vitobotta]

Hi @21h and @AMecea , I have tried several times with the changes shown in this PR, and I can install the operator with these changes, but backups do not work for some reason. If I install with Helm 2, backups work just fine. @21h Have you tested backups with your changes? Thanks!

[vitobotta]

I have a doubt.... I have only made the changes to the CRD file and moved it to the crds directory. Do I need to use the script generate_chart_manifests.sh as well? Thanks

[vitobotta]

In the logs for the failing backup jobs I see this:

sidecar take backup command failed      {"error": "getting backup: fail to get backup: Get http://mysql-cluster-mysql-0.mysql.mysql:8080/xbackup: dial tcp: i/o timeout, code: unknown"}

I tried to curl Is mysql-cluster-mysql-0.mysql.mysql:8080 from a Ubuntu container in the same namespace and I could connect. I wonder why the backup job cannot connect to it?

[vitobotta]

I found my problem.... Even though I checked out the 0.3.8 tag, the images in the values.yaml are set to "latest", instead of "0.3.8". Changing that fixes the backups.

[AMecea]

Closing this in favor of #468. In #468 I've cherry-picked your commits and squashed them and add the rest of changes. Please test it and let me know it solves your problem. Thank you for your contribution!