Update controller-util, fixes cascade deletion issue #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMecea
force-pushed
the
update-controller-util
branch
from
5f06d22 to
5ebafe1
Compare
chapsuk
pushed a commit
to chapsuk/mysql-operator
that referenced
this pull request
Oct 16, 2023
In order for dynamic local storage provisioners to influence pod scheduling for future PV creation, ensure the vtbackup data PVC exists before the Pod. This matches the order in reconcile_tablets.go. Decouple the orphan Pod detection for pods of all phases (Pending, Running, Succeeded, Failed, Unknown). Ensure that temporary node failures marking pods as Failed do not inadvertently delete PVCs until reconciling a termination of the Pod. Fixes: bitpoke#221 Signed-off-by: Sean Treadway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates controller-util to version
v0.1.8which contains a fix for cascade deletion.