Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform with kubernetes recommended labels #132

Closed
calind opened this issue Oct 17, 2018 · 0 comments · Fixed by #181
Closed

Conform with kubernetes recommended labels #132

calind opened this issue Oct 17, 2018 · 0 comments · Fixed by #181
Milestone
0.2.3

Comments

@calind
Copy link
Member

calind commented Oct 17, 2018 •
edited
Loading

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/. We should set them on cluster subresources and on pods.

  • app.kubernetes.io/name -> mysql
  • app.kubernetes.io/instance -> MysqlCluster.Labels[app.kubernetes.io/instance] or MysqlCluster.Name
  • app.kubernetes.io/version -> image tag
  • app.kubernetes.io/component -> MysqlCluster.Labels[app.kubernetes.io/component] or database
  • app.kubernetes.io/part-of -> MysqlCluster.Labels[app.kubernetes.io/part-of]
  • app.kubernetes.io/managed-by -> mysql-operator.presslabs.org
@calind calind added this to the 0.2.x milestone Nov 20, 2018
@calind calind modified the milestones: 0.2.x, 0.2.2 Nov 29, 2018
@AMecea AMecea mentioned this issue Dec 12, 2018
Merged
@calind calind modified the milestones: 0.2.x, 0.2.3 Jan 7, 2019
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this issue Oct 16, 2023
@enisoc
Add/remove partitionings in place. (bitpoke#132)
3a6cf4d 
Always immediately add or remove partitionings to stay in sync with the
desired set of partitionings, even if changes to existing partitionings
are held back by the update strategy. The deployment of new things or
the removal of unwanted things should not need to wait for an external
rollout.

Signed-off-by: Anthony Yeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.3
Development

Successfully merging a pull request may close this issue.

Use K8s recommended labels bitpoke/mysql-operator
2 participants
@calind @AMecea