Use upstream swift support plugin #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vially
changed the title
|
Hi, Im having the exact same problem since upgrading to cordova v8. |
|
This is a good one to merge! Solved my problem, thanks :D |
|
Fantastic, thanks @vially! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
cordova-plugin-qrscannerworks just fine with the upstream cordova-plugin-add-swift-support.I'm not sure what was the original reason for forking it into cordova-plugin-swift-support and using that, but it seems today using
cordova-plugin-add-swift-supportworks great.It even has some bug fixes which are not present in the forked version which prevents
cordova-plugin-qrscannerfrom installing correctly on version8ofcordova-cli.