Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser dependencies when skipBrowser is enabled will still download. #21

Open
braydonf opened this issue Feb 3, 2015 · 3 comments
Open

Comments

@braydonf
Copy link
Contributor

braydonf commented Feb 3, 2015

Firstly, when skipBrowsers is enabled, the browser dependencies still need to be installed. Second, "phantomjs" is downloaded by "karma-detect-browsers" even though it's not used (even when browser tasks are enabled).

@braydonf
Copy link
Contributor Author

braydonf commented Apr 2, 2015

Phantom JS is disabled in our options, but it still downloads. Is there a way that we can remove this dependency, maybe with npm shrinkwrap?

> [email protected] install node_modules/bitcore-build/node_modules/karma-phantomjs-launcher/node_modules/phantomjs
> node install.js

Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-1.9.8-linux-x86_64.tar.bz2
Receiving...
  [======================------------------] 54% 0.0s

@maraoz
Copy link
Contributor

maraoz commented Apr 2, 2015

Yes... This is really annoying.

On Wed, Apr 1, 2015, 22:05 Braydon Fuller [email protected] wrote:

Phantom JS is disabled in our options, but it still downloads. Is there a
way that we can remove this dependency, maybe with npm shrinkwrap?

[email protected] install node_modules/bitcore-build/node_modules/karma-phantomjs-launcher/node_modules/phantomjs
node install.js

Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-1.9.8-linux-x86_64.tar.bz2
Receiving...
[======================------------------] 54% 0.0s

Reply to this email directly or view it on GitHub
#21 (comment).

@braydonf
Copy link
Contributor Author

braydonf commented Apr 2, 2015

Perhaps there is an option we can use to configure the dependency: litixsoft/karma-detect-browsers#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants